Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: unit test configuration handles deferred var @{x} from surefire/failsafe #1827

Merged
merged 2 commits into from
Nov 26, 2024
Merged

FIX: unit test configuration handles deferred var @{x} from surefire/failsafe #1827

merged 2 commits into from
Nov 26, 2024

Conversation

treilhes
Copy link
Contributor

@treilhes treilhes commented Sep 9, 2024 •
edited by HannesWell
Loading

Fixes #1824
Fixes #1832

@treilhes treilhes mentioned this pull request Sep 9, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

Test Results

  321 files  ±0    321 suites  ±0   52m 42s ⏱️ + 1m 25s
  680 tests +2    659 ✅ ±0  20 💤 +2  0 ❌ ±0  1 🔥 ±0 
2 040 runs  +6  1 979 ✅ ±0  60 💤 +6  0 ❌ ±0  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit 1e30cab. ± Comparison against base commit 3af1fc5.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the fix/resolve_deferred_vars_for_unit_tests_config branch from 894ebef to 0e823b3 Compare October 3, 2024 07:00
@treilhes treilhes force-pushed the fix/resolve_deferred_vars_for_unit_tests_config branch from 0e823b3 to 19a6a90 Compare October 11, 2024 22:11
@HannesWell HannesWell force-pushed the fix/resolve_deferred_vars_for_unit_tests_config branch from 9ffa6f3 to 1e30cab Compare November 26, 2024 06:37
HannesWell
HannesWell approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these fixes @treilhes and sorry for the late reply.

I made a few small adjustments in UnitTestSupport.resolveDeferredVariables() to be more precise in case of multiple occurrences of equal placeholders (although the result should be the same) and to handle a null value or empty properties.

I plan to submit this change this evening. Please let me know if you are not fine with any adjustments.

@HannesWell HannesWell merged commit 85b9ac8 into eclipse-m2e:master Nov 26, 2024
7 of 8 checks passed
@HannesWell
Copy link
Contributor

Thanks again.

Btw. I noticed that the tests you added are skipped in the CI. Locally they passed, but it would be good to have them running.
Could you please look into that?

@HannesWell HannesWell added this to the 2.7.0 milestone Nov 26, 2024
@treilhes
Copy link
Contributor Author

Hello @HannesWell

I don't have anything against your adjustments

About the unit tests not runninig, from my limited knowledge it seems neither junit or testng features are installed in the eclipse test environment which lead to disabled test.
If you can give me some pointers about where to look at for seting the features deployed in the test instance i will gladly give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckart reckart reckart left review comments

@HannesWell HannesWell HannesWell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
3 participants
@treilhes @HannesWell @reckart